Projects:RTL/Development Status
Contents |
Right To Left Support - Development Status
Overview
The development of Right To Left Support project intends to give Openbravo ERP an rtl aspect, in order to support rtl-written languages. In this document is going to be registered each change made, as well as its status.
Development evolution can also be tracked at rtl branch.
Important notes:
- The tasks do not have to be made, necessarily, in the order listed below.
- Files to be modified are the ones listed inside Path column. No other file different from these ones needs to be modified nor committed to the development branch.
- Once a task has been accomplished, please change Status cell to complete with the link to the commit to the branch (as explained in Openbravo bug reporting guidelines):
| class="green_cell" | Complete
Build.xml files modifications
Modifications in the skins: build.xml file modification.
| Type of file | Path | Change made | Comments | Status |
| Build.xml files | /src/build.xml | Modified some ant tasks in order to create two different folders for each skin: rtl and ltr. Furthermore, a piece of java code must be executed in the rtl folder. | Complete |
New Java Class
Modifications in the skins: New Java Class in src-trl.
| Type of file | Path | Change made | Comments | Status |
| RTLSkin.java | /src-trl/src/org/openbravo/translate/RTLSkin.java | Created a new class, called from Build.xml after creating context, that will implement changes needed in rtl skin. | Complete | |
| RTLSkin.java | /src-trl/src/org/openbravo/translate/RTLSkin.java | RTLSkin.java flips images (with help of FlipImage.java) contained in a text file. | Complete | |
| FlipImage.java | /src-trl/src/org/openbravo/translate/FlipImage.java | Java class that flips horizontally a gif or png image. | Complete |
Update Paths To Skin
| Type of file | Path | Change made | Comments | Status |
| src/org/openbravo/erpCommon/security/Login.java | src/org/openbravo/erpCommon/security/Login.java | Find and replace all the relative paths to the skin | Complete | |
| src/org/openbravo/erpCommon/security/Login_F1.xml | src/org/openbravo/erpCommon/security/Login_F1.xml | Find and replace all the relative paths to the skin | Complete | |
| src/org/openbravo/erpCommon/security/Login_Welcome.xml | src/org/openbravo/erpCommon/security/Login_Welcome.xml | Find and replace all the relative paths to the skin | Complete | |
| Openbravo_ERP_240.css | web/skins/Default/Openbravo_ERP_240.css | Find and replace all the relative paths to the skin | Complete | |
| Openbravo_ERP_250.css | web/skins/Default/Openbravo_ERP_250.css | Find and replace all the relative paths to the skin | Complete |
Add RTL Check In Language Window
| Type of file | Path | Change made | Comments | Status |
| IsRTL new check in AD_LANGUAGE window | src-db/database/model/tables/AD_LANGUAGE.xml, src-db/database/sourcedata/AD_COLUMN.xml, src-db/database/sourcedata/AD_ELEMENT.xml, src-db/database/sourcedata/AD_FIELD.xml and src-db/database/sourcedata/AD_LANGUAGE.xml. | IsRTL new check in AD_LANGUAGE window | Complete |
Linking languages to skins
| Type of file | Path | Change made | Comments | Status |
| DefaultOptions_data.xsql | src/org/openbravo/base/secureApp/DefaultOptions_data.xsql | When obtaining languages from database, obtain as well the IsRTL column value. | Complete | |
| HttpSecureAppServlet.java | src/org/openbravo/base/secureApp/HttpSecureAppServlet.java | When obtaining language to use, obtain as well the IsRTL value. | Complete | |
| LoginUtils.java | src/org/openbravo/base/secureApp/LoginUtils.java | fillSessionArguments function sets session variables in any session begining. When setting #Theme session variable, if language is rtl, then the "rtl/" string is concatenated at the begining; if language is ltr, then the "ltr/" string is concatenated at the begining. | Complete | |
| Role.java and Role_data.xsql | src/org/openbravo/erpCommon/ad_forms/Role.java src/org/openbravo/erpCommon/ad_forms/Role_data.xsql | When changing Role (and language, so) the rtl column value of the selected language is consulted in database, and provided to fillSessionArguments function. | Complete | |
| ShowSessionPreferences.java | src/org/openbravo/erpCommon/ad_forms/Role.java | When session preferences are set, the rtl value is taken into account. | Complete | |
| LoginUtils.java | src/org/openbravo/base/secureApp/LoginUtils.java | Sets session variable #TextDirection. | Complete | |
| Role.java | src/org/openbravo/erpCommon/ad_forms/Role.java | Set #TextDirection session variable, and give to Role.html this value for it to pass it through javascript to frameset html page. | Complete | |
| Role.html and Role.xml | src/org/openbravo/erpCommon/ad_forms/Role.html and src/org/openbravo/erpCommon/ad_forms/Role.xml | Set 'isRTL' variable of the frameset page according to selected language and re-draw framset page. | Complete | |
| Login.java | src/org/openbravo/erpCommon/security/Login.java | According to session variable, call to frameset html file with a rtl structure, or a ltr structure. | Complete | |
| Login_FS.html | src/org/openbravo/erpCommon/security/Login_FS.html | Include a javascript variable IsRTL, to report any open html file if it is chosen a rtl or a ltr language. | Complete | |
| Login_FS_RTL.html and Login_FS_RTL.xml | src/org/openbravo/erpCommon/security/Login_FS_RTL.html and src/org/openbravo/erpCommon/security/Login_FS_RTL.xml | Copy of Login_FS.html and Login_FS.xml, but with a rtl structure. | Complete | |
| Menu.java | src/org/openbravo/erpCommon/security/Menu.java | According to session variable, call to frameset html file with a rtl structure, or a ltr structure. | Complete | |
| Home.java and Home.html | src/org/openbravo/erpCommon/security/Home.java and src/org/openbravo/erpCommon/security/Home.html | According to a xml parameter, show the arrow that shows/hides the menu at right or left side of the frame. | Complete | |
| appStatus.js and utils.js | web/js/AppStatus.java and web/js/utils.java | Sets the correct frames width according to rtl/ltr language in show/hide menu and show/hide loading frame functions. | Complete |