Projects:Enable Read-Only Pool per report/QA

Unit tests

OBDal functionality is covered by DalTest, which includes tests where the read-only pool is requested

Manual tests

To test that the desired pool is returned when requesting it to OBDal, a number of manual tests were created in Test Link. The purpose of the tests is to cover all possible configurations of Preference/Data Pool Selection entries:

This test the Preference value is used when no Data Pool Selection entries were made (the scenario where the second column in the table above is "-")

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10903

This scenario covers the case where Data Pool Selection overrides the default preference. Specifically the second row, where selected reports should use the default pool even though the default was set to RO.

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10904

Performance

This project should not have a noticeable impact in OBDal performance as the Database access required to retrieve the Preference and the DataPoolSelection entries are made only once when application starts and then it is cached.

The new Report selector, however, have been tested to ensure the data is retrieved in a reasonable amount of time. In order to test that, it is measured the time it takes the OBUIAPP_Pool_Report Datasource to retrieve data under various scenarios. The following table shows the mean time of each of these actions in Postgres/Oracle:

Code review

https://docs.google.com/spreadsheets/d/17LgLD1AsEyyALu_aYg2Sfw9rrPMV0efXVLq71mDCC7o